feat(logger): preserve manual trace declarations in OTLP spans - #295
Draft
pradystar wants to merge 3 commits into
Draft
pradystar wants to merge 3 commits into
pradystar wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
- Capture immutable trace fields on direct operation spans - Keep automatic handler envelopes unmarked - Reject known local trace redeclarations - Deprecate start_trace timing and external ID arguments - Add regression coverage and document backend compatibility
Merge origin/main and resolve logger and decorator conflicts. Carry explicit conclude output and redacted output as trace attributes on direct operations under declared trace envelopes. Keep sibling spans and the frozen start declaration unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves fields supplied to start_trace() by attaching splunk_ao.trace.* attributes to direct operation spans. Trace fields remain separate from operation content, without creating an artificial root span or adding trace CRUD calls.
Requires the corresponding Orbit Go ingestion changes to project these attributes into backend trace records.
Validation: 177 relevant tests passed; Ruff lint and formatting checks passed.