fix: Preserve unknown API enum values - #301
Open
jonahe wants to merge 2 commits into
Open
jonahe wants to merge 2 commits into
jonahe wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I have read the CLA Document and I hereby sign the CLA |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
recheck |
Sorry, something went wrong.
1 task
New server enum values can break parsing of successful API responses. Preserve known enum members and retain unfamiliar strings and integers without changing constants or discriminator fields. Update generation and SDK consumers to handle these values explicitly.
jonahe
force-pushed
the
codex/tolerate-unknown-api-enums
branch
from
2cbc894 to
0898dbb
Compare
November 5, 2026 19:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New server enum values can make successful API responses fail during
parsing, including project lookups with a capability_based creator role.
Preserve known enum members and carry unfamiliar values as raw strings
or integers so reading and serializing newer responses stays compatible.
Generate explicit enum-or-primitive field types while retaining
constants and explicitly closed enums. Keep collaborator roles and
generic providers usable, and report unsupported evaluator types instead
of guessing their implementation. No API changes are required.