Make splunklin.binding.ResponseReader.readline function. - #121
Closed
cjw296 wants to merge 1 commit into
Closed
cjw296 wants to merge 1 commit into
cjw296 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@cjw296 sorry for the delayed response. Could you:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Given this software is so poor, I'm unlikely to bother with a wet-ink contributor agreement. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped into this trying to do:
>>> conn = client.connect(...) >>> result = conn.jobs.export('search ...', output_mode='csv') >>> result.readline() '"'The problem is the 1 byte peek followed by a one byte read here:
https://hg.python.org/cpython/file/v2.7.5/Modules/_io/iobase.c#l466
This results in an attempt to read 0 bytes from the HTTPResponse in result._response, which ends up hitting this code path:
https://hg.python.org/cpython/file/v2.7.5/Lib/httplib.py#l567
We ask for 0 bytes, and sure enough, we get 0 bytes, but httplib sees this as "no data left" and closes the connection.
I couldn't figure out how best to test this, or indeed, how to run the test suite in such a way that the existing tests on HEAD of master all passed before I started work. But, functional testing has shown this to work.