FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

properly add parameters to request based on the method of the request by billmurrin · Pull Request #262 · splunk/splunk-sdk-python · GitHub

  1. splunk
  2. splunk-sdk-python

Repository navigation

properly add parameters to request based on the method of the request - #262

Merged
ashah-splunk merged 2 commits into
splunk:developfrom
billmurrin:hotfix/261-context-request-get-parameters
Dec 15, 2021
ConversationCommits (2)ChecksFiles changed
Merged

properly add parameters to request based on the method of the request#262
ashah-splunk merged 2 commits into
splunk:developfrom
billmurrin:hotfix/261-context-request-get-parameters

Conversation

billmurrin commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

This PR resolves #261 related to improper handling of body parameters within the Context.request method. The method used (GET or POST) will determine if the body is encoded as part of the url or passed as body into the request.

GET method requests (with and without a body) were tested and worked as expected.

billmurrin changed the base branch from master to develop July 24, 2019 03:07
billmurrin changed the base branch from develop to master July 24, 2019 03:08
shakeelmohamed suggested changes Jul 26, 2019
View reviewed changes

shakeelmohamed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR @billmurrin, we will take a look at sorting out the CI issue

Comment thread splunklib/binding.py Resolved

billmurrin commented Aug 9, 2019

Copy link
Copy Markdown
Contributor Author

Hi @shakeelmohamed. I've implemented the requested changes in the latest commit. Thanks!

billmurrin commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Hi @shakeelmohamed - the requested changes were made. For some reason, the CI issue is still ongoing.

shakeelmohamed commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

@billmurrin This is not a high priority issue for us to investigate as we are severely under resourced at the moment. Unless this is 10/10 we will not look at it this week. Thank you for your patience & understanding.

cc @tdhellmann

KaterinaKop commented Feb 25, 2021 •
edited
Loading

Copy link
Copy Markdown

Any news here? We are looking forward to get this fix too!
@shakeelmohamed @tdhellmann

ashah-splunk changed the base branch from master to develop December 14, 2021 16:12
ashah-splunk merged commit e5402ee into splunk:develop Dec 15, 2021
akaila-splunk mentioned this pull request Mar 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
shakeelmohamed shakeelmohamed requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible Bug with binding class request method related to GET parameters

4 participants

Back | FazBrowse Home | New Git URL