FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix duplicate TOC in Sphinx docs and automate bundling of docs by fantavlik · Pull Request #365 · splunk/splunk-sdk-python · GitHub

Repository navigation

Fix duplicate TOC in Sphinx docs and automate bundling of docs - #365

Merged
fantavlik merged 2 commits into
developfrom
fix-docs-gen
Feb 9, 2021
Merged

fantavlik merged 2 commits into
developfrom
fix-docs-gen

Conversation

Copy link
Copy Markdown
Contributor

Provide easier docs bundling with tox environment and Sphinx installed as part of new 'make docs' command.

Comment thread docs/index.rst
Welcome to the API reference for the Splunk SDK for Python, which describes the modules that are included in the SDK.
For more information, see the `Splunk Developer Portal <http://dev.splunk.com/view/python-sdk/SP-CAAAEBB>`_.

.. toctree::

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This seemed to be the cause of the duplicate TOC

Comment thread tox.ini
[testenv:docs]
description = invoke sphinx-build to build the HTML docs
basepython = python3.7
deps = sphinx >= 1.7.5, < 2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

By running this as a tox command we can let tox install sphinx in a Python 3 environment and skip those steps as part of docs generation

Comment thread tox.ini
setenv = SPLUNK_HOME=/opt/splunk
INPUT_EXAMPLE_UPLOAD=/opt/splunk/var/log/splunk/splunkd_ui_access.log
whitelist_externals = true
allowlist_externals = make

fantavlik Jan 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This tells tox that it's OK to run make in the docs command below, see: https://tox.readthedocs.io/en/latest/example/basic.html?highlight=make#allowing-non-virtualenv-commands

Copy link
Copy Markdown
Contributor Author

I will wait to merge this until @PKing70 has a chance to look at the latest generated docs for v1.6.15 and verifies that the new script is producing sane-looking docs

fantavlik merged commit a97c1d8 into develop Feb 9, 2021
fantavlik deleted the fix-docs-gen branch February 9, 2021 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL