Break out search argument to option parsing for v2 custom search commands - #392
Merged
fantavlik merged 1 commit intoDec 9, 2021
Merged
fantavlik merged 1 commit into
fantavlik merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
acharlieh
marked this pull request as draft
August 29, 2021 23:39
This should be a passive change, while providing a useful extension point.
acharlieh
force-pushed
the
configurable_options
branch
from
35f0540 to
8cea66f
Compare
August 29, 2021 23:48
Copy link
Copy Markdown
Contributor
Author
|
Helps if I make the pull request against the correct branch. |
Sorry, something went wrong.
acharlieh
marked this pull request as ready for review
August 29, 2021 23:56
Copy link
Copy Markdown
Contributor
|
Looks good to me since there are no functional changes for end users, good luck @acharlieh |
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I was wanting to write a custom search command, but for reasons of making things similar to existing commands, and because what I'm needing to take as positional parameters could have equals signs in them, I wanted to parse options that look like --optionName=optionValue instead of optionName=optionValue
Digging through the SDK I think I found the point where we were doing this, and wrapped it in a method so that I could override this parsing, but keep everything else passive for others who are already using the SDK.
I could see a future extension point where this entire parsing out options might be able to be overridden/modified, but I didn't have a need for that much customization yet.