FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move CI tests in Python SDK to Github Actions from TravisCI by akaila-splunk · Pull Request #399 · splunk/splunk-sdk-python · GitHub

  1. splunk
  2. splunk-sdk-python

Repository navigation

Move CI tests in Python SDK to Github Actions from TravisCI - #399

Merged
akaila-splunk merged 4 commits into
developfrom
DVPL-10027
Sep 28, 2021
ConversationCommits (4)ChecksFiles changed
Merged

Move CI tests in Python SDK to Github Actions from TravisCI#399
akaila-splunk merged 4 commits into
developfrom
DVPL-10027

Conversation

akaila-splunk commented Sep 24, 2021

Copy link
Copy Markdown
Contributor
  • Added test.yml file for test cases execution on push and PR
  • Remove .travis.yml file

fantavlik requested changes Sep 24, 2021
View reviewed changes

fantavlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In general these changes look good and I don't expect all tests to pass at this point but a number of the jobs are terminating with: Error: The operation was canceled. could you possibly investigate those issues before merging this work? We'll also want to followup once we know which tests are failing and fix or skip those tests after investigating but that can be a followup task. For now I just want to make sure that all tests are being executed and not running into the above error.

Update test.yml
261a943 
- set fail-fast: false so GitHub will not cancels all in-progress jobs if any matrix job fails.

akaila-splunk commented Sep 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

GitHub cancels all in-progress jobs with error Error: The operation was canceled if any matrix job fails. that's the reason we are getting this error for other jobs when one of the job fails.
I have changed code as suggested and now all the jobs are running even if any job fails.

fantavlik commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

GitHub cancels all in-progress jobs with error Error: The operation was canceled if any matrix job fails. that's the reason we are getting this error for other jobs when one of the job fails.
I have changed code as suggested and now all the jobs are running even if any job fails.

Excellent, that's good to know - thanks for investigating.

fantavlik approved these changes Sep 27, 2021
View reviewed changes

fantavlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome work - let's merge this. Can you also create a followup ticket to address the test failures now that we can see those? That will be high priority.

akaila-splunk commented Sep 28, 2021

Copy link
Copy Markdown
Contributor Author

Awesome work - let's merge this. Can you also create a followup ticket to address the test failures now that we can see those? That will be high priority.

Sure, I'll create ticket for test failures.

akaila-splunk merged commit 709806e into develop Sep 28, 2021
vmalaviya-splunk mentioned this pull request Nov 1, 2021
Merged
akaila-splunk deleted the DVPL-10027 branch May 2, 2022 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fantavlik fantavlik approved these changes
zenmoto Awaiting requested review from zenmoto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL