Fix test case failure for 8.0 and latest(8.2.x) splunk version - #404
Merged
ashah-splunk merged 6 commits intoOct 14, 2021
Merged
ashah-splunk merged 6 commits into
ashah-splunk merged 6 commits into
Conversation
- Replace deprecated apps/appinstall endpoint with apps/local
Passing input Kind as multiple modular inputs have "input" with name "default"
fantavlik
reviewed
Oct 13, 2021
Comment thread
.github/workflows/test.yml
| echo version=${{ matrix.splunk }} >> .splunkrc | ||
| - name: Create build dir for ExamplesTestCase::test_build_dir_exists test case | ||
| run: | | ||
| cd ~ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this line can be removed
Sorry, something went wrong.
fantavlik
approved these changes
Oct 13, 2021
fantavlik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor comment about a line that can be removed but otherwise looks great, glad to see things all green again 🚀
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.