Default kvstore owner to nobody - #413
Merged
ashah-splunk merged 6 commits intoNov 10, 2021
Merged
ashah-splunk merged 6 commits into
ashah-splunk merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
default value for owner set to "nobody"
commenting the need to set kvstore owner to default value of "nobody" as new property is created for the kvstore owner with default to "nobody"
fantavlik
approved these changes
Nov 9, 2021
fantavlik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, thanks for updating testcases for both the default case (nobody) and override case (admin) 🚀
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new property for the kvstore owner, which is set to "nobody" by default. But a setter is added for future purpose when the owner value is required to be changed