Added new github_commit modular input example - #426
Merged
ashah-splunk merged 2 commits intoJan 5, 2022
Merged
ashah-splunk merged 2 commits into
ashah-splunk merged 2 commits into
Conversation
- updated docker-compose.yml file that will mount the example and splunklib directory during docker container spin up process - added instruction in readme.md file for how to run example
fantavlik
approved these changes
Jan 4, 2022
fantavlik
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor comments about copyright year and naming convention but in general this is working and looking good to merge, nice work!
Sorry, something went wrong.
Comment thread
examples/github_commits/bin/github_commits.py
Resolved
Comment thread
examples/github_commits/bin/github_commits.py
Resolved
ashah-splunk
approved these changes
Jan 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.