FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added setup_logging() method in splunklib for logging and updated README.md files by akaila-splunk · Pull Request #437 · splunk/splunk-sdk-python · GitHub

  1. splunk
  2. splunk-sdk-python

Repository navigation

added setup_logging() method in splunklib for logging and updated README.md files - #437

Merged
akaila-splunk merged 3 commits into
developfrom
DVPL-10608
Mar 4, 2022
ConversationCommits (3)ChecksFiles changed
Merged

added setup_logging() method in splunklib for logging and updated README.md files#437
akaila-splunk merged 3 commits into
developfrom
DVPL-10608

Conversation

akaila-splunk commented Mar 3, 2022

Copy link
Copy Markdown
Contributor
  • Used module-specific logger in splunklib code instead of root logger
  • Added new setup_logging() method in splunklib to set logging level, log format(optional) and date format(optional)
  • Updated REAME.md file with details of setup_logging() method
  • Updated searchcommands_app/README.md file with some details of logging.conf file and how to see debug logs
  • Here is an example of log message,
Before code change:
	DEBUG:root:Log message
After code change:
	2022-03-03 19:12:58 India Standard Time, Level=DEBUG, Pid=11120, Logger=splunklib.binding, File=binding.py, Line=72, Log message

Used module-specific logger in splunklib code instead of root logger
00fadcb
add method to set logging for splunklib directory
ec06849
add formatter for logs and update README.md file
fbeff52 
- add default time and log formatter in setup_logging() method
- add details of setup_logging() method and logging.conf files in README.md file
fantavlik approved these changes Mar 4, 2022
View reviewed changes

fantavlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well done! Thanks for walking us through the design along the way on our weekly syncs

akaila-splunk merged commit f1db833 into develop Mar 4, 2022
akaila-splunk mentioned this pull request Mar 25, 2022
Merged
majiang mentioned this pull request Mar 30, 2022
Closed
akaila-splunk deleted the DVPL-10608 branch May 2, 2022 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fantavlik fantavlik approved these changes
zenmoto Awaiting requested review from zenmoto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL