update support for accelerated_field of kvstore - #500
Merged
akaila-splunk merged 4 commits intoJan 31, 2023
Merged
akaila-splunk merged 4 commits into
akaila-splunk merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fantavlik
reviewed
Jan 10, 2023
Comment thread
splunklib/client.py
Resolved
fantavlik
requested changes
Jan 10, 2023
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Recommend adding accelerated fields support without removing current functionality if possible
Since this functionality was deprecated in 7.x I'm good with moving forward.
Sorry, something went wrong.
vishwambhar
approved these changes
Jan 23, 2023
fantavlik
approved these changes
Jan 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated accelerated_field methods and added test cases for it. (issue #497 for ref)