Fixed things found in session 1 of the grand Python review. - #59
madhadron merged 1 commit into
Conversation
Sorry, something went wrong.
- Added a note that Confs as been renamed to Configurations in CHANGELOG.md. - Entity.refresh no longer tries to interpret HTTPErrors, and just lets them bubble up. Fixed test_delete tests in test_input, test_role, test_saved_search, and test_user to expect HTTPError instead of EntityDeletedException. Deleted EntityDeletedException since it is not longer used. - Fixed namespace logic in Entity._proper_namespace to draw on the entity's own namespace before the service's namespace. - Moved AmbiguousReferenceException throwing from _load_state in Entity to _load_atom_entry (where it should be). - Fixed doctoring of Service.search to indicate that it returns a Job, not the results of a oneshot search. - Edited a comment that was too Freddian for public consumption. - Moved URL-unquoting of links from refresh to read on Entity, and made it a UrlEncoded step instead of unencoding them.
There was a problem hiding this comment.
Not English. :) Should be something like:
"The jobs endpoint only returns an outermost element, instead of an outermost element with an element embedded inside."
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed.
Sorry, something went wrong.
|
Changes look good, modulo comments. Prior to merge, let's have Brad take a look. Also, I'd like us to write some tests for the namespace thing, I don't know if we have any that specifically test that, but we should if we don't. |
Sorry, something went wrong.
|
Added some tests on the namespace thing. |
Sorry, something went wrong.
|
Going to have a bunch more. We can have Brad look at the whole mess. |
Sorry, something went wrong.
Fixed things found in session 1 of the grand Python review.
* Add ai_custom_alert_app * Disable app by default * PR fixes #1 * PR fixes * Update README.md
test_role, test_saved_search, and test_user to expect HTTPError instead of EntityDeletedException. Deleted EntityDeletedException
since it is not longer used.