Resolve warnings emitted by tests - #667
Merged
mateusz834 merged 1 commit intoSep 10, 2025
Merged
mateusz834 merged 1 commit into
mateusz834 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
For the vast majority of warnings, I have simply added a skip, since we cannot remove tests for deprecated APIs. See: https://docs.python.org/3.6/library/warnings.html#temporarily-suppressing-warnings Additionally, to eliminate warnings caused by invalid test classes, I renamed two classes to avoid using the “TestNAME” pattern, as such names are automatically recognized as test classes.
mateusz834
force-pushed
the
dev/MP/resolve-tests-warnings
branch
from
6d59ac7 to
5dd2203
Compare
September 8, 2025 10:02
mateusz834
marked this pull request as ready for review
September 8, 2025 13:01
cecyliaborek
approved these changes
Sep 9, 2025
cecyliaborek
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👌
Sorry, something went wrong.
cecyliaborek
reviewed
Sep 9, 2025
Comment thread
tests/unit/searchcommands/test_search_command.py
Resolved
Ickerday
approved these changes
Sep 9, 2025
Copy link
Copy Markdown
Collaborator
|
BTW, could we also close #638 with this one? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the vast majority of warnings, I have simply added a skip, since we cannot remove tests for deprecated APIs.
See: https://docs.python.org/3.6/library/warnings.html#temporarily-suppressing-warnings
Additionally, to eliminate warnings caused by invalid test classes, I renamed two classes to avoid using the “TestNAME” pattern, as such names are automatically recognized as test classes.