Replace tox with pytest and Makefile, cleanup in docs/Makefile - #669
Merged
Ickerday merged 34 commits intoSep 26, 2025
Merged
Ickerday merged 34 commits into
Ickerday merged 34 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Ickerday
force-pushed
the
dev/BJ/docs-bugfixes
branch
from
d073d5d to
60df5a0
Compare
September 9, 2025 14:21
cecyliaborek
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
great cleanup ✨
Sorry, something went wrong.
Ickerday
force-pushed
the
dev/BJ/docs-bugfixes
branch
from
fd3310d to
8e99721
Compare
September 16, 2025 15:21
Ickerday
marked this pull request as ready for review
September 19, 2025 14:52
… 'restructuredtext'}`."
Ickerday
force-pushed
the
dev/BJ/docs-bugfixes
branch
from
12c99e8 to
37d5537
Compare
September 22, 2025 15:29
mateusz834
reviewed
Sep 23, 2025
Comment thread
Makefile
Resolved
Comment thread
Makefile
Resolved
Comment thread
README.md
Resolved
Comment thread
Makefile
Resolved
Comment thread
.github/workflows/test.yml
Resolved
Comment thread
.github/workflows/release.yml
Resolved
mateusz834
reviewed
Sep 25, 2025
Comment thread
splunklib/binding.py
Resolved
mateusz834
approved these changes
Sep 26, 2025
mateusz834
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good.
Sorry, something went wrong.
Comment thread
README.md
Resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Verify I replaced all tox usages with alternatives, update docs
Confusingly tox is now a psuedo-Makefile, lists project dependencies, runs an almost random assortment of scripts and whatever else. I want to bring order to this chaos.
I also want to remove all the commands we don't use in docs' Makefile. Maybe move it to the main Makefile if possible.