SDK-21 add deps of test apps into bin/ - #671
Merged
cecyliaborek merged 1 commit intoSep 16, 2025
Merged
cecyliaborek merged 1 commit into
cecyliaborek merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Ickerday
reviewed
Sep 10, 2025
Comment thread
.gitignore
Resolved
Ickerday
approved these changes
Sep 10, 2025
cecyliaborek
marked this pull request as ready for review
September 16, 2025 07:42
cecyliaborek
force-pushed
the
dev/CB/SDK-21-dependencies-in-bin
branch
from
b424ed5 to
c64aa8b
Compare
September 16, 2025 07:50
cecyliaborek
force-pushed
the
dev/CB/SDK-21-dependencies-in-bin
branch
from
c64aa8b to
758b0cb
Compare
September 16, 2025 07:51
mateusz834
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Splunk documentation and best practices, Python apps should package their dependencies in the bin/ directory rather than lib/. This avoids the need to manually add lib/ to the Python path (e.g., using sys.path.insert).
This PR updates our SDK test apps to follow this approach.