FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add GoogleModel support by szykol · Pull Request #727 · splunk/splunk-sdk-python · GitHub

Repository navigation

Add GoogleModel support - #727

Merged
szykol merged 1 commit into
developfrom
skolton/gemini-support
May 7, 2026
Merged

szykol merged 1 commit into
developfrom
skolton/gemini-support

Conversation

szykol commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

This PR adds support to Google Models via:

  • Gemini API
  • VertexAI

The actual backend used depends on the parameters passed to GoogleModel

szykol force-pushed the skolton/gemini-support branch 3 times, most recently from 52cbd48 to 8bcd6bf Compare April 17, 2026 12:10

szykol commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

update:

Those changes were tested with Gemini models through Gemini API.
The thought signature issue that we had when using Gemini models through OpenAI compatible API is (partially) gone now.
However, our SDK does not preserve the though signatures in it's own types and this works only because the langchain-google-genai package uses dummy thought signatures when original ones (generated by the model) are missing.

I imagine we're gonna need to include the original though signatures when passing new messages to the Gemini model, but this requires a couple of changes to the SDK code - mainly how we handle content of AIMessage. Currently we're dumping everything to string, but some model providers return content blocks instead of strings there. Gemini models include thought signatures inside those content blocks (if not calling tools). If calling tools, the though signature is stored in the additional_kwargs field of AIMessage.

Once we'll fix handling content in AIMessages we can continue with this PR. It's already in progress.

Ickerday marked this pull request as draft April 23, 2026 13:30
Ickerday self-requested a review April 23, 2026 13:43
szykol force-pushed the skolton/gemini-support branch from 8bcd6bf to 843e406 Compare April 24, 2026 07:37
szykol changed the base branch from develop to skolton/ai-message-content-fixes April 24, 2026 07:39
szykol force-pushed the skolton/ai-message-content-fixes branch 12 times, most recently from fba91ce to a14c18e Compare April 27, 2026 13:31
Base automatically changed from skolton/ai-message-content-fixes to develop April 27, 2026 14:12
szykol force-pushed the skolton/gemini-support branch 3 times, most recently from 61a8771 to 2285029 Compare April 28, 2026 11:15
szykol force-pushed the skolton/gemini-support branch 5 times, most recently from 9906da4 to 9db5e77 Compare May 6, 2026 08:40
This PR adds support to Google Models via:
- Gemini API
- VertexAI

The actual backend used depends on the parameters passed to GoogleModel
szykol force-pushed the skolton/gemini-support branch from 9db5e77 to 3d64456 Compare May 7, 2026 09:56
szykol marked this pull request as ready for review May 7, 2026 09:58
szykol merged commit 568cddc into develop May 7, 2026
5 of 6 checks passed
szykol deleted the skolton/gemini-support branch May 7, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL