FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Run ruff format on repo by Ickerday · Pull Request #744 · splunk/splunk-sdk-python · GitHub

Repository navigation

Run ruff format on repo - #744

Merged
Ickerday merged 4 commits into
developfrom
chore/adjust-linter-formatter-config
May 8, 2026
Merged

Ickerday merged 4 commits into
developfrom
chore/adjust-linter-formatter-config

Conversation

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .github/workflows/lint.yml Resolved
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from 5ddc2c2 to bc51c97 Compare April 27, 2026 16:12
Ickerday changed the title Add ruff to lint.yml Add ruff to lint stage, fix some discovered import/export issues etc. Apr 27, 2026
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from bc51c97 to 4e405a1 Compare April 27, 2026 16:35
Comment thread splunklib/modularinput/event.py Resolved
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from 4e405a1 to f9b8a78 Compare April 28, 2026 12:44
Ickerday marked this pull request as ready for review April 28, 2026 13:24
Ickerday force-pushed the chore/adjust-linter-formatter-config branch 3 times, most recently from a8bbeca to 1bcf46c Compare April 29, 2026 20:03

mateusz834 commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Is this PR fully automatic, or are here any manual changes? Its hard for me to review this change. Please update the PR description to include such details what this change does.

The best way to approach such changes is to separate these i.e. one PR (or just commit) that does a format and second that does changes to fix say lint issues required to enable it in CI, otherwise such PRs require huge review burden to get through merging it. Since now this change requires a review of every single file, instead of just the 2nd PR/commit and it is super easy to miss important changes, that are not related to formatting changes.

Ickerday force-pushed the chore/adjust-linter-formatter-config branch 3 times, most recently from 8d89f97 to b6d27ce Compare May 7, 2026 13:00
Ickerday changed the title Add ruff to lint stage, fix some discovered import/export issues etc. Run ruff format on repo May 7, 2026
Comment thread Makefile Resolved
Comment thread Makefile Resolved
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from b6d27ce to b583b21 Compare May 7, 2026 15:31
Ickerday enabled auto-merge (squash) May 7, 2026 15:33
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from 236bdb2 to 8d438c3 Compare May 8, 2026 12:32
Ickerday force-pushed the chore/adjust-linter-formatter-config branch from 8d438c3 to 7fc618d Compare May 8, 2026 12:56
Ickerday merged commit b3deb09 into develop May 8, 2026
5 of 6 checks passed
Ickerday deleted the chore/adjust-linter-formatter-config branch May 8, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL