Disallow running Agents using system user - #753
Merged
szykol merged 1 commit intoApr 29, 2026
Merged
szykol merged 1 commit into
szykol merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
szykol
force-pushed
the
skolton/system-tokens
branch
2 times, most recently
from
5c7216a to
0fdd2d4
Compare
April 29, 2026 07:55
mateusz834
reviewed
Apr 29, 2026
Comment thread
splunklib/ai/utils.py
Resolved
szykol
force-pushed
the
skolton/system-tokens
branch
2 times, most recently
from
ab92641 to
c0cc8cd
Compare
April 29, 2026 11:27
szykol
marked this pull request as ready for review
April 29, 2026 11:27
mateusz834
reviewed
Apr 29, 2026
Comment thread
splunklib/ai/security.py
Resolved
mateusz834
reviewed
Apr 29, 2026
Comment thread
splunklib/ai/security.py
Resolved
mateusz834
approved these changes
Apr 29, 2026
mateusz834
reviewed
Apr 29, 2026
Comment thread
tests/unit/ai/test_security.py
Resolved
szykol
force-pushed
the
skolton/system-tokens
branch
from
c0cc8cd to
3d4caee
Compare
April 29, 2026 12:12
szykol
force-pushed
the
skolton/system-tokens
branch
from
3d4caee to
83092ce
Compare
April 29, 2026 12:14
mateusz834
approved these changes
Apr 29, 2026
mateusz834
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🚀
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running agents with system user (splunk-system-user) should not be allowed - such user has permissions to do anything within splunk. Giving this capability to Agent should result in an error being thrown.
Developers should not pass Service objects that use the system tokens to the Agent.