Add thread_id to middlewares - #755
Merged
mateusz834 merged 1 commit intoMay 5, 2026
Merged
mateusz834 merged 1 commit into
mateusz834 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
2 times, most recently
from
7259546 to
338f820
Compare
April 29, 2026 13:12
mateusz834
marked this pull request as ready for review
April 29, 2026 13:13
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
2 times, most recently
from
0fd896e to
29bea8d
Compare
April 29, 2026 13:15
szykol
reviewed
Apr 29, 2026
Comment thread
tests/integration/ai/test_agent.py
Resolved
szykol
reviewed
Apr 29, 2026
Comment thread
splunklib/ai/engines/langchain.py
Resolved
szykol
approved these changes
Apr 29, 2026
Additionally make sure that subagents get an unique thread_id when no conversation store is being used. And enforce that thread_id cannot be an empty string, as that is clearly a bug.
mateusz834
force-pushed
the
dev/MP/thread-id-middlewares
branch
from
29bea8d to
11d5bcb
Compare
May 4, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally make sure that subagents get an unique thread_id when no conversation store is being used.
And enforce that thread_id cannot be an empty string, as that is clearly a bug.