test: Pass fake api_key to the internal ai model - #764
Merged
szykol merged 1 commit intoMay 5, 2026
Merged
szykol merged 1 commit into
szykol merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Ickerday
approved these changes
May 5, 2026
mateusz834
approved these changes
May 5, 2026
mateusz834
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please update the description and title, since this is no longer a test.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Sorry for poor wording, I wanted to note that this is related to tests only, not that this was used for testing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of openai library (v2.34.0) requires the api_key to be non-empty.
This fails our e2e tests, since we didn't use the api_key.
This PR fixes this by passing some fake api_key to the OpenAIModel for tests.