Remove total_steps and token_count from AgentState - #770
Merged
mateusz834 merged 1 commit intoMay 11, 2026
Merged
mateusz834 merged 1 commit into
mateusz834 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
bc3ab13 to
67be015
Compare
May 8, 2026 10:04
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
8a0d9bd to
26468f3
Compare
May 8, 2026 10:04
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
67be015 to
8877f69
Compare
May 8, 2026 11:17
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
26468f3 to
3b63421
Compare
May 8, 2026 11:17
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
8877f69 to
a2ea91a
Compare
May 8, 2026 11:24
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
2 times, most recently
from
d3e0ca5 to
451c178
Compare
May 8, 2026 11:31
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
451c178 to
1feeaf6
Compare
May 8, 2026 11:45
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
a2ea91a to
c149ff6
Compare
May 8, 2026 11:57
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
1feeaf6 to
acf8e13
Compare
May 8, 2026 11:57
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
c149ff6 to
7ca19f6
Compare
May 8, 2026 12:18
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
acf8e13 to
26fefda
Compare
May 8, 2026 12:18
mateusz834
marked this pull request as ready for review
May 8, 2026 12:21
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
26fefda to
6b26c3c
Compare
May 8, 2026 13:17
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
2 times, most recently
from
03591d5 to
f0ab600
Compare
May 8, 2026 13:19
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
2 times, most recently
from
9ae8747 to
ff52383
Compare
May 8, 2026 14:02
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
f0ab600 to
d1647fd
Compare
May 11, 2026 07:51
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
2 times, most recently
from
08a40e1 to
f4e4a52
Compare
May 11, 2026 08:25
mateusz834
force-pushed
the
dev/MP/limits-as-settings
branch
from
d1647fd to
4904ce4
Compare
May 11, 2026 08:25
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
2 times, most recently
from
b4cf77d to
ee0855a
Compare
May 11, 2026 10:17
szykol
approved these changes
May 11, 2026
Steps can be inferred from len(messages). Additionally this fixes a bug, where model middleware overrides messages, without updating the total_steps/token_count field. As this is an easy mistake to do, i don't think it is worth exposing such fields.
mateusz834
force-pushed
the
dev/MP/remove-total_steps
branch
from
ee0855a to
0af71db
Compare
May 11, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps can be inferred from len(messages).
Additionally this fixes a bug, where model middleware overrides messages, without updating the total_steps/token_count field. As this is an easy mistake to do, i don't think it is worth exposing such fields.
This change also makes sure we take into account tool definitions in token use calculations.