This repository was archived by the owner on Apr 5, 2022. It is now read-only.
Fixed id reuse (causing object overwrite) issue for inner objects defined in <constructor-arg> without an explicit id value. - #4
Open
eecswangxu wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ined in <constructor-arg> without an explicit id value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using spring-python to create objects based on XML files, and came across errors when defining inner objects in without specifying id values. It seems the inner objects without explicit id values could have the same id values generated, e.g. someprefix.constr., thus actually use the same object. To make such inner object id optional, I made the code changes to generate unique ids.