| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks, @izeye. It's a shame that we missed this. I've opened #30901 to see if we can stop if from happening again. There is a workaround for the missing property, but it's not very elegant: @Bean
StatsdConfig statsdConfig(StatsdProperties statsdProperties) {
return new StatsdPropertiesConfigAdapter(statsdProperties) {
@Override
public boolean buffered() {
return false;
}
};
}
As such, I am a bit tempted to treat this as a bug and fix it in 2.5.x. Flagging for team attention to see what everyone else thinks. |
Sorry, something went wrong.
|
I think it's reasonable to consider this a bug of omission. |
Sorry, something went wrong.
|
@wilkinsona I don't have much experience working with StatsD, but it seems to have been missed unintentionally, too and it sounds reasonable to align configurability level with its corresponding meter registry configuration. /cc @shakuzen |
Sorry, something went wrong.
|
Statsd's step makes sense to expose as a configuration property and I suspect we just missed it. |
Sorry, something went wrong.
Sorry, something went wrong.
|
@wilkinsona Sure, I pushed ccbe758 for it. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR changes to expose buffered property for StatsdConfig.
See micrometer-metrics/micrometer#1375