FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix minor version and cleanup action by sbihel · Pull Request #4 · spruceid/didkit-python · GitHub

This repository was archived by the owner on Jul 10, 2025. It is now read-only.
/ didkit-python Public archive

Fix minor version and cleanup action - #4

Merged
sbihel merged 14 commits into
mainfrom
fix/release-versions
Mar 16, 2022
Merged

Fix minor version and cleanup action#4
sbihel merged 14 commits into
mainfrom
fix/release-versions

Conversation

sbihel commented Mar 16, 2022

Copy link
Copy Markdown
Member

Certain odd linux architectures are stuck on 3.8 (e.g. arm, or powerpc) but now all OS with their major archs have 3.7--3.10 available.

Wheels artifacts available under e.g. https://github.com/spruceid/didkit-python/actions/runs/1989782516

Close #2
Close #3

sbihel requested a review from clehner March 16, 2022 00:02
sbihel merged commit e76a893 into main Mar 16, 2022
sbihel deleted the fix/release-versions branch March 16, 2022 09:54

clehner commented Mar 16, 2022

Copy link
Copy Markdown

Nice.
Here's a diff of the wheels built from https://github.com/spruceid/didkit-python/actions/runs/1989898370 (#1) to https://github.com/spruceid/didkit-python/actions/runs/1956614557 (338ceb7)

+didkit-0.3.0-cp310-cp310-macosx_10_7_x86_64.whl
+didkit-0.3.0-cp310-cp310-macosx_11_0_arm64.whl
 didkit-0.3.0-cp310-cp310-manylinux_2_12_i686.manylinux2010_i686.whl
 didkit-0.3.0-cp310-cp310-manylinux_2_12_x86_64.manylinux2010_x86_64.whl
 didkit-0.3.0-cp310-none-win32.whl
 didkit-0.3.0-cp310-none-win_amd64.whl
 didkit-0.3.0-cp36-cp36m-manylinux_2_12_i686.manylinux2010_i686.whl
 didkit-0.3.0-cp36-cp36m-manylinux_2_12_x86_64.manylinux2010_x86_64.whl
+didkit-0.3.0-cp37-cp37m-macosx_10_7_x86_64.whl
+didkit-0.3.0-cp37-cp37m-macosx_11_0_arm64.whl
 didkit-0.3.0-cp37-cp37m-manylinux_2_12_i686.manylinux2010_i686.whl
 didkit-0.3.0-cp37-cp37m-manylinux_2_12_x86_64.manylinux2010_x86_64.whl
 didkit-0.3.0-cp37-none-win32.whl
 didkit-0.3.0-cp37-none-win_amd64.whl
+didkit-0.3.0-cp38-cp38-macosx_10_7_x86_64.whl
+didkit-0.3.0-cp38-cp38-macosx_11_0_arm64.whl
 didkit-0.3.0-cp38-cp38-manylinux_2_12_i686.manylinux2010_i686.whl
 didkit-0.3.0-cp38-cp38-manylinux_2_12_x86_64.manylinux2010_x86_64.whl
+didkit-0.3.0-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
+didkit-0.3.0-cp38-cp38-manylinux_2_17_armv7l.manylinux2014_armv7l.whl
+didkit-0.3.0-cp38-cp38-manylinux_2_17_ppc64.manylinux2014_ppc64.whl
+didkit-0.3.0-cp38-cp38-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl
+didkit-0.3.0-cp38-cp38-manylinux_2_17_s390x.manylinux2014_s390x.whl
 didkit-0.3.0-cp38-none-win32.whl
 didkit-0.3.0-cp38-none-win_amd64.whl
 didkit-0.3.0-cp39-cp39-macosx_10_7_x86_64.whl
-didkit-0.3.0-cp39-cp39-macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2.whl
+didkit-0.3.0-cp39-cp39-macosx_11_0_arm64.whl
 didkit-0.3.0-cp39-cp39-manylinux_2_12_i686.manylinux2010_i686.whl
 didkit-0.3.0-cp39-cp39-manylinux_2_12_x86_64.manylinux2010_x86_64.whl
-didkit-0.3.0-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
-didkit-0.3.0-cp39-cp39-manylinux_2_17_armv7l.manylinux2014_armv7l.whl
-didkit-0.3.0-cp39-cp39-manylinux_2_17_ppc64.manylinux2014_ppc64.whl
-didkit-0.3.0-cp39-cp39-manylinux_2_17_ppc64le.manylinux2014_ppc64le.whl
-didkit-0.3.0-cp39-cp39-manylinux_2_17_s390x.manylinux2014_s390x.whl
 didkit-0.3.0-cp39-none-win32.whl
 didkit-0.3.0-cp39-none-win_amd64.whl
 didkit-0.3.0-pp37-pypy37_pp73-manylinux_2_12_i686.manylinux2010_i686.whl

sbihel commented Mar 16, 2022

Copy link
Copy Markdown
Member Author

Ah thanks, that's a better way of showing the changes. As you can see in the end it mainly fixes macos by generating all python versions. And I decided to stop using universal2 and have native packages.

Comment on lines +68 to +69
env:
PYO3_CROSS_LIB_DIR: /opt/python/cp38-cp38/lib

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why 3.8 rather than 3.9?
If this env var is removed, would builds be made for all the available binding versions on {aarch64, armv7, s390x, ppc64le, ppc64} like for {x86_64, i686} - or is this env var required for cross-compiling other than from x86_64 to i686?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's required for builds that use manylinux (so all but x86 and i686) -- 3.7 wasn't working, I suppose we could add a matrix for 3.8 and 3.9 (maybe 3.10). And I decreased to 3.8 because I'm still not sure whether wheels can be forced to be used from a new Python version.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install from PyPI not working on macos arm64

2 participants


Back | FazBrowse Home | New Git URL