FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: provide context loader for json-ld methods by GlugovGrGlib · Pull Request #8 · spruceid/didkit-python · GitHub

This repository was archived by the owner on Jul 10, 2025. It is now read-only.
/ didkit-python Public archive

feat: provide context loader for json-ld methods - #8

Closed
GlugovGrGlib wants to merge 1 commit into
spruceid:mainfrom
GlugovGrGlib:feat/add_context_loader_param
Closed

feat: provide context loader for json-ld methods#8
GlugovGrGlib wants to merge 1 commit into
spruceid:mainfrom
GlugovGrGlib:feat/add_context_loader_param

Conversation

Copy link
Copy Markdown

This PR adds support for ContextLoader feature which introduced in: spruceid/ssi#432 and spruceid/didkit#298.

We, at openedx.org, want to use didkit-python to issue OpenBadgesV3 with StatusList2021 support. Although this kind of functionality was already added to ssi, changes in this PR must be applied to fix an error[E0061] when building against the latest versions of didkit and ssi.

This PR was tested locally by building didkit-python using main branch for didkit and ssi.

Do I understand correctly, to release a new didkit-python version with these changes, it's necessary to republish didkit on crates.io, and then update the version and the list of features in Cargo.toml, as currently enabled features were already removed from didkit?

This commit solves an error[E0061] when building against latest versions of the didkit and ssi libraries

Copy link
Copy Markdown
Author

@sbihel Kindly ask you for a review

sbihel commented Mar 3, 2023

Copy link
Copy Markdown
Member

Thanks for the PR. Just to confirm, we are talking about this context file https://github.com/spruceid/ssi/blob/main/contexts/jff-vc-edu-plugfest-2-context.json ?

Yes, I'll need to publish new versions of ssi and didkit -- is it ok if it is done next week?

Copy link
Copy Markdown
Author

Thanks for the PR. Just to confirm, we are talking about this context file https://github.com/spruceid/ssi/blob/main/contexts/jff-vc-edu-plugfest-2-context.json ?

Yes, this context is required for our use case.

Yes, I'll need to publish new versions of ssi and didkit -- is it ok if it is done next week?

Sure, this will be great, thank you!

sbihel closed this in #9 Mar 9, 2023
sbihel added a commit that referenced this pull request Mar 9, 2023
Also remove Linux architectures without ring support

Close #8
GlugovGrGlib deleted the feat/add_context_loader_param branch March 9, 2023 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL