Switch from yarn@1.22.22 to pnpm@11.0.8 by karlhorky · Pull Request #949 · sql-formatter-org/sql-formatter · GitHub

Switch from yarn@1.22.22 to pnpm@11.0.8, as per #945 (comment).

This also pins @types/node@22.9.0, matching the version previously resolved through yarn.lock. Without the pin, pnpm resolves @types/node@25.6.0, which TypeScript 4.9 cannot check. The observed diagnostics:

error TS1165: A computed property name in an ambient context must refer to an expression whose type is a literal type or a 'unique symbol' type
error TS2339: Property 'dispose' does not exist on type 'SymbolConstructor'
error TS2726: Cannot find lib definition for 'esnext.disposable'

Install pnpm via the methods on the installation page:

https://pnpm.io/installation

TODO:

Delete yarn.lock
Generate pnpm-lock.yaml
Update package scripts from Yarn commands to pnpm commands
Update GitHub Actions from Yarn commands to pnpm commands
Update contributor docs from Yarn commands to pnpm commands
Remove the README install example with Yarn
Update CI from Node 18 to Node 22 for pnpm 11 compatibility
Enable pnpm dependency caching in CI
Pin devEngines.packageManager to pnpm@11.0.8
Pin @types/node@22.9.0
Verify dependencies before scripts with verifyDepsBeforeRun: error
Declare the root workspace package with packages: ['.']
Block packages newer than seven days with minimumReleaseAge: 10080
Apply release-age checks strictly with minimumReleaseAgeStrict: true
Treat missing publish times as unsafe with minimumReleaseAgeIgnoreMissingTime: false
Prevent trust downgrades with trustPolicy: no-downgrade
Allow the trust-policy exception eslint-config-prettier@8.10.2
Allow the trust-policy exception eslint-plugin-prettier@4.2.5
Allow the trust-policy exception semver@5.7.2 || 6.3.1
Allow the trust-policy exception undici-types@6.19.8
Block exotic subdependencies with blockExoticSubdeps: true

Summary by CodeRabbit

Chores
- Updated CI and project tooling to Node.js 22.x.
- Migrated package management from Yarn to pnpm across CI, scripts, and project config.
- Added a pnpm workspace with stricter dependency and verification policies.
- Updated developer scripts and bumped dev tooling/type dependency versions.
Documentation
- Updated install and contribution instructions to reflect pnpm and Node.js 22.x.

@coderabbitai review

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Migrate CI and project configuration from Yarn to pnpm and upgrade Node.js targets to 22.x; update package scripts, add a pnpm workspace config, and adjust CONTRIBUTING/README instructions.

Changes

Package Manager and Node.js Migration

Layer / File(s)	Summary
Node.js 22 and dependency updates .github/workflows/coveralls.yaml, .github/workflows/webpack.yaml, package.json	Node.js version updated from 18.x to 22.x in CI matrices; @types/node bumped to 22.9.0.
pnpm workspace and package manager configuration pnpm-workspace.yaml, package.json	Added pnpm-workspace.yaml with strict pnpm settings and migrated package.json scripts and devEngines.packageManager from yarn to pnpm.
GitHub Actions workflow pnpm integration .github/workflows/coveralls.yaml, .github/workflows/webpack.yaml	Coveralls and webpack workflows now set up pnpm/action-setup@v6, enable pnpm caching via actions/setup-node@v4, install with pnpm install --ignore-scripts, and run CI steps via pnpm run ....
Contributor and user documentation CONTRIBUTING.md, README.md	CONTRIBUTING.md replaced yarn instructions with pnpm equivalents; README consolidated install snippet to a single npm install line noting alternatives (yarn/pnpm/bun).

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant PnpmSetup as pnpm/action-setup@v6
  participant SetupNode as actions/setup-node@v4
  participant Runner
  GitHubActions->>PnpmSetup: install pnpm (version from package.json)
  GitHubActions->>SetupNode: configure Node 22.x + cache: pnpm
  Runner->>Runner: pnpm install --ignore-scripts
  Runner->>Runner: pnpm run lint / pnpm run test -- --coverage / pnpm run build / pnpm run ts:check

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 From Yarn to pnpm I bound and cheer,
Node twenty-two now leads the year,
CI swaps scripts for speedy runs,
Workspace rules keep builds well-spun,
I hop, I nibble, change is near!

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title directly and precisely describes the main change: migrating the project's package manager from yarn to pnpm with specific versions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch switch-from-yarn-v1-to-pnpm-v11

Comment @coderabbitai help to get the list of available commands and usage tips.

Node.js 18 and 20 are EOL

Pull request overview

Switches the project’s development package manager from Yarn Classic to pnpm, updating docs, scripts, CI, and pnpm workspace/security configuration.

Changes:

Replaces Yarn commands with pnpm commands in scripts, docs, and GitHub Actions.
Adds pnpm workspace configuration and pnpm lockfile.
Pins @types/node and updates CI to Node 22 with pnpm caching/Corepack.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
README.md	Updates install example from Yarn to pnpm.
CONTRIBUTING.md	Updates contributor setup, test, and release commands to pnpm.
package.json	Converts scripts to pnpm and pins pnpm/@types/node metadata.
pnpm-workspace.yaml	Adds pnpm workspace and security-related settings.
pnpm-lock.yaml	Adds pnpm dependency lockfile.
yarn.lock	Removes legacy Yarn lockfile.
.github/workflows/webpack.yaml	Updates PR CI workflow to Node 22 and pnpm.
.github/workflows/coveralls.yaml	Updates coverage workflow to Node 22 and pnpm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/coveralls.yaml:
- Line 18: The CI job step using the pnpm/action-setup action (the step that
currently references "pnpm/action-setup@v6") should explicitly pin the pnpm
version via the action input to avoid the resolution bug; update that workflow
step to include a with: version: 11.0.8 (matching devEngines.packageManager) so
the action always installs pnpm 11.0.8 instead of relying on the action's
bootstrap resolution.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2015d31c-949c-4022-9627-680b0483090c

📥 Commits

Reviewing files that changed from the base of the PR and between f03823a and 2f7e7a9.

📒 Files selected for processing (4)

.github/workflows/coveralls.yaml
.github/workflows/webpack.yaml
README.md
pnpm-workspace.yaml

🚧 Files skipped from review as they are similar to previous changes (3)

.github/workflows/webpack.yaml
README.md
pnpm-workspace.yaml

In general I'm all good with this.

The single showstopper for me is the pmOnFail issue. If we could just add to the config file:

pmOnFail: download

Then I would be fine with merging this. Even when this gets fixed in pnpm, the old pnpm versions with this issue will still be around for a while, troubling people who would like to check out this library.

@nene Good point, I forgot that I wanted to add that as a workaround - done:

dcee63f

Awesome.

The single showstopper for me is the pmOnFail issue. If we could just add to the config file:
pmOnFail: download
Good point, I forgot that I wanted to add that as a workaround - done:

I've upgraded to pnpm 11.9.0 and reverted the workaround here:

Upgrade to pnpm@11.9.0, remove pmOnFail: download config #957

Upgrade to [`pnpm@11.9.0`](https://github.com/pnpm/pnpm/releases/tag/v11.9.0) and remove `pmOnFail: download` workaround: - #949 (review) - my pnpm issue: pnpm/pnpm#11676 - pnpm PR that fixed it: pnpm/pnpm#11682 - pnpm release v11.1.3 that contained the fix: https://github.com/pnpm/pnpm/releases/tag/v11.1.3#:~:text=Fix%20devEngines.packageManager%20(singular%20form%2C%20without%20onFail)%20defaulting%20to%20onFail%3A%20%22error%22%20instead%20of%20the%20documented%20pmOnFail%3A%20%22download%22

Copilot AI review requested due to automatic review settings May 14, 2026 13:25

Copilot started reviewing on behalf of karlhorky May 14, 2026 13:25 View session

karlhorky mentioned this pull request May 14, 2026

Add devEngines.packageManager field to package.json #945

Merged

karlhorky commented May 14, 2026

View reviewed changes

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread .github/workflows/webpack.yaml Outdated

Comment thread .github/workflows/coveralls.yaml Outdated

Comment thread package.json

Comment thread pnpm-lock.yaml

coderabbitai Bot reviewed May 14, 2026

View reviewed changes

Comment thread .github/workflows/coveralls.yaml

karlhorky mentioned this pull request May 14, 2026

action-setup@v6 does not install pnpm version specified in package_json_file pnpm/action-setup#227

Open

karlhorky requested a review from nene May 14, 2026 14:14

nene reviewed May 14, 2026

View reviewed changes

Comment thread package.json

Comment thread .github/workflows/webpack.yaml

Comment thread pnpm-workspace.yaml Outdated

Comment thread pnpm-workspace.yaml Outdated

karlhorky added 10 commits May 14, 2026 23:04

Switch from yarn@1.22.22 to pnpm@11.0.8

71b0abc

Order alphabetically, add links

1b71182

Remove pnpm code block from readme

0b512da

Fix pnpm setup in CI

1b15780

Remove superfluous --frozen-lockfile flag

a0411aa

Work around pnpm/action-setup@6 version bug

31274c0

Remove periods

4459421

Fix pnpm version extraction in CI

e40ed48

Unconfigure pmOnFail back to default 'download'

13aa127

Remove erroneous and superfluous settings

78b508b

karlhorky force-pushed the switch-from-yarn-v1-to-pnpm-v11 branch from 249ea2b to 78b508b Compare May 14, 2026 21:04

nene reviewed May 15, 2026

View reviewed changes

Comment thread package.json

Comment thread pnpm-workspace.yaml Outdated

Add comments for trustPolicyExclude entries

b1d7dc6

karlhorky commented May 15, 2026

View reviewed changes

Comment thread pnpm-workspace.yaml Outdated

karlhorky mentioned this pull request May 15, 2026

pmOnFail does not default to 'download' with devEngines.packageManager pnpm/pnpm#11676

Closed

4 tasks

Switch to trustPolicyIgnoreAfter

ce140ed

karlhorky requested a review from nene May 17, 2026 09:43

nene reviewed May 17, 2026

View reviewed changes

Work around pnpm bug with pmOnFail + devEngines.packageManager

dcee63f

Ignore pnpm-lock.yaml from Prettier

ba7437e

nene approved these changes May 17, 2026

View reviewed changes

nene merged commit af633e8 into master May 17, 2026
2 checks passed

karlhorky deleted the switch-from-yarn-v1-to-pnpm-v11 branch May 17, 2026 16:30

karlhorky mentioned this pull request Jun 26, 2026

Upgrade to pnpm@11.9.0, remove pmOnFail: download config #957

Merged

                   strategy:
                     matrix:
-                      node-version: [18.x]
+                      node-version: [22.x]

Switch from yarn@1.22.22 to pnpm@11.0.8 by karlhorky · Pull Request #949 · sql-formatter-org/sql-formatter · GitHub

Uh oh!

Switch from yarn@1.22.22 to pnpm@11.0.8 - #949

Switch from yarn@1.22.22 to pnpm@11.0.8#949nene merged 14 commits intomastersql-formatter-org/sql-formatter:masterfrom switch-from-yarn-v1-to-pnpm-v11sql-formatter-org/sql-formatter:switch-from-yarn-v1-to-pnpm-v11Copy head branch name to clipboard

Conversation

karlhorky commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

karlhorky commented May 14, 2026

Uh oh!

coderabbitai Bot commented May 14, 2026

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Uh oh!

karlhorky May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nene left a comment

Choose a reason for hiding this comment

Uh oh!

karlhorky commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nene left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karlhorky commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Switch from yarn@1.22.22 to pnpm@11.0.8#949
nene merged 14 commits into
masterfrom
switch-from-yarn-v1-to-pnpm-v11

karlhorky commented May 14, 2026 •
edited
Loading

coderabbitai Bot commented May 14, 2026 •
edited
Loading

karlhorky commented May 17, 2026 •
edited
Loading