FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Load test.db sqlite database demo file by eSlider · Pull Request #3 · sql-js/react-sqljs-demo · GitHub

/ react-sqljs-demo Public template

Load test.db sqlite database demo file - #3

Open
eSlider wants to merge 1 commit into
sql-js:masterfrom
produktor:feature/load-db
ConversationCommits (1)ChecksFiles changed
Open

Load test.db sqlite database demo file#3
eSlider wants to merge 1 commit into
sql-js:masterfrom
produktor:feature/load-db

Conversation

eSlider commented Jun 14, 2020 •
edited
Loading

Copy link
Copy Markdown

As discussed in previous PR I improved live-demo by add database file load example to become abilities run SQL queries on it.

Changes

  • Download demo sqlite database file using fetch
  • Prepare downloaded file to handle it right ( ArrayBuffer => Uint8Array )
  • Add default select SQL query in textearea

lovasoa requested changes Jun 14, 2020
View reviewed changes

lovasoa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice !

Two little things :

  • it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
  • The default query should be executed immediately once the database has been loaded.

eSlider commented Jun 15, 2020

Copy link
Copy Markdown
Author

Nice !

Two little things :

  • it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
  • The default query should be executed immediately once the database has been loaded.

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

lovasoa commented Jun 15, 2020

Copy link
Copy Markdown
Member

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

The Dallas Police Officer-Involved Shootings is great. It is small enough to load quickly, is not copyrighted, and contains interesting public data, with several tables that can be joined. If you find or create another database that meets these criteria and want to include it instead, go ahead; but I don't think the Dallas PD data has any reason for being controversial.

zmwm37 added a commit to zmwm37/react-sqljs-demo that referenced this pull request Apr 28, 2021
update demo with pull request sql-js#3 with sample sqlite databases
f59bcf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lovasoa lovasoa requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL