Repository navigation
Fix Any overloads for inspect() raiseerr handling - #13710
Open
princejain756 wants to merge 2 commits into
Open
princejain756 wants to merge 2 commits into
princejain756 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks! Issue #13704 is now marked code review in progress and no longer open for pull requests, so this pull request holds the review for it and another one won't land on top of your work. If this pull request is abandoned, a maintainer can put open for pull requests back on #13704 to reopen it to others. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
thanks, looks ok! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes: #13704
Description
Update the fallback @overload signatures for inspect(subject: Any, ...) in lib/sqlalchemy/inspection.py so the default raiseerr: Literal[True] = ... -> Any overload precedes raiseerr: bool -> Optional[Any]: