FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[DuckDB] feat: Query index information for DuckDB dynamically by ahmed-kamal2004 · Pull Request #1171 · sqlancer/sqlancer · GitHub

/ sqlancer Public

[DuckDB] feat: Query index information for DuckDB dynamically - #1171

Closed
ahmed-kamal2004 wants to merge 4 commits into
sqlancer:mainfrom
ahmed-kamal2004:duck
ConversationCommits (4)ChecksFiles changed
Closed

[DuckDB] feat: Query index information for DuckDB dynamically#1171
ahmed-kamal2004 wants to merge 4 commits into
sqlancer:mainfrom
ahmed-kamal2004:duck

Conversation

ahmed-kamal2004 commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

This PR resolves issue #1163

Before change

sqlancer/src/sqlancer/duckdb/gen/DuckDBIndexGenerator.java

Line 26 in 7fbfe3d

sb.append(Randomly.fromOptions("i0", "i1", "i2", "i3", "i4")); // cannot query this information

The indexes names are hard-coded, there is no way AFAIK to store or retrieve them

After change

  • store the indexes information in the table schema
  • extend SQLancer ability to generate random indexes for DuckDB testing, this ensures unique indexes names up to 100 index_name, now indexes names generation strategy is limited by ‎AbstractSchema::getFreeIndexName only.

Snippet of the generated creation statements for Indexes

Files Changed

  • DuckDBIndexGenerator.java : [OLD-Remved] random selection of indexes names out of a defined set of names - [NEW-Added] following generation strategy implemented & used by other database engines implementations
  • DuckDBSchema.java : [NEW-Added] store indexes information inside DuckDBTable object for further using

Testing

  • Running for almost 2.5 million queries on DuckDB

    command used java -jar sqlancer-*.jar --num-threads 4 duckdb --oracle NOREC

mrigger mentioned this pull request Mar 20, 2025
Closed
5 tasks
mrigger reviewed Mar 23, 2025
View reviewed changes

mrigger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR! I have added some improvement suggestions.

Comment thread src/sqlancer/duckdb/DuckDBSchema.java Outdated

}

public static final class DuckDBIndex extends TableIndex {

mrigger Mar 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we could actually just use the TableIndex class here instead.

Comment thread src/sqlancer/duckdb/DuckGlobalState.java Outdated

import sqlancer.SQLGlobalState;

public class DuckGlobalState extends SQLGlobalState<DuckDBOptions, DuckDBSchema> {

mrigger Mar 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We already have a global state class for DuckDB.

ahmed-kamal2004 requested a review from mrigger March 23, 2025 16:06

mrigger commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Thanks a lot for the PR! It looks good to me, but it seems the tests are currently failing due to a test oracle report. Could you perhaps try reducing the bug-inducing test cases? It might be a bug in DuckDB.

mrigger commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Based on the current output, it seems that we are repeatedly generating indexes with the same name, so it seems like there might be another issue.

ahmed-kamal2004 commented Mar 29, 2025

Copy link
Copy Markdown
Contributor Author

@mrigger actually yes this is another issue, but is it was already here before the change, what I thinking of as a solution for this to get indexes with diff names is to use counter and reset "whenever needed like on schema change".

mrigger commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

This functionality is already present in SQLancer and also other DBMSs use it. In the DuckDBIndexGenerator, when instantiating the SQLQueryAdapter, you can see that an argument is set that indicates a schema change.

mrigger closed this Apr 3, 2025
Elshaarawy-1 added a commit to Elshaarawy-1/sqlancer that referenced this pull request Feb 11, 2026
Add DuckDBSchema.getIndexes() implementation
e039cba 
Based on PR sqlancer#1171
Addresses sqlancer#1163
Elshaarawy-1 mentioned this pull request Feb 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mrigger Awaiting requested review from mrigger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL