Unify INSERT/UPDATE/DELETE generators under AbstractGenerator hierarchy - #1334
Merged
mrigger merged 2 commits intoApr 22, 2026
Merged
Unify INSERT/UPDATE/DELETE generators under AbstractGenerator hierarchy#1334mrigger merged 2 commits into
mrigger merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mrigger
force-pushed
the
refactor/abstract-generator-hierarchy
branch
2 times, most recently
from
ed4d1ff to
b136e40
Compare
April 21, 2026 08:24
Introduce AbstractDeleteGenerator extending AbstractGenerator, and make AbstractInsertGenerator and AbstractUpdateGenerator also extend it, eliminating duplicate sb/errors field declarations across all generator classes. Convert all 15 DELETE generators (CockroachDB, Databend, Doris, DuckDB, H2, MariaDB, Materialize, MySQL, OceanBase, Postgres, Presto, SQLite3, TiDB, YCQL, YSQL) from static-utility classes to the instance-based buildStatement() pattern. Add canonicalizeString field to AbstractGenerator (defaulting to true) so generators like Presto/Hive/Spark can opt out of semicolon canonicalization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mrigger
force-pushed
the
refactor/abstract-generator-hierarchy
branch
from
b136e40 to
38d14b4
Compare
April 21, 2026 16:07
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mrigger
force-pushed
the
refactor/abstract-generator-hierarchy
branch
from
a4f78e8 to
0eea021
Compare
April 22, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce AbstractDeleteGenerator extending AbstractGenerator, and make AbstractInsertGenerator and AbstractUpdateGenerator also extend it, eliminating duplicate sb/errors field declarations across all generator classes.
Convert all 15 DELETE generators (CockroachDB, Databend, Doris, DuckDB, H2, MariaDB, Materialize, MySQL, OceanBase, Postgres, Presto, SQLite3, TiDB, YCQL, YSQL) from static-utility classes to the instance-based buildStatement() pattern. Add canonicalizeString field to AbstractGenerator (defaulting to true) so generators like Presto/Hive/Spark can opt out of semicolon canonicalization.