Do not schedule disabled PostgreSQL tablespaces - #1350
Merged
mrigger merged 1 commit intoJul 30, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the PR! I think it might be better to solve this issue at a higher level. If tablespaces are disabled, I think that PostgresTableSpaceGenerator.generate() should never be called by the StatementExecutor. Could you check whether this would be possible? |
Sorry, something went wrong.
splf-jojo
force-pushed
the
fix/postgres-tablespace-npe
branch
from
c5229c2 to
2a74be3
Compare
July 30, 2026 11:51
mrigger
approved these changes
Jul 30, 2026
mrigger
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, thanks for the PR. Also great that you added the test case to ensure we won't have a regression. Will merge after the checks pass.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When PostgreSQL tablespace testing is disabled, PostgresProvider.mapActions()
now assigns zero executions to CREATE_TABLESPACE. Consequently,
StatementExecutor never selects that action and never calls
PostgresTableSpaceGenerator.generate().
Following the review feedback, this moves the guard up to the scheduling layer,
rather than handling an already-selected action inside the generator.
This removes the previous generator-level IgnoreMeException approach. The
generator is now skipped entirely when tablespace testing is disabled.
Testing