This fixes handling of sqlc.arg() inside ORDER BY expressions during named parameter rewriting.
While testing queries using named parameters in conditional ordering logic, I noticed that parameters used inside ORDER BY expressions were not being rewritten correctly. The rewrite flow was missing these cases during parameter processing.
This change updates the rewrite handling and adds regression test coverage for the behavior.
Example
Query:
SELECT ID
FROM Sequence
WHERE SeriesID = ?1ORDER BY (Name =sqlc.arg(name)) DESC, ID
LIMIT1;
Before this change, the named parameter inside the ORDER BY expression was not rewritten correctly.
After this change, sqlc.arg(name) is properly detected and rewritten during parameter processing.
Changes
Updated named parameter rewrite handling for ORDER BY expressions
Added regression test coverage in parameters_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes handling of sqlc.arg() inside ORDER BY expressions during named parameter rewriting.
While testing queries using named parameters in conditional ordering logic, I noticed that parameters used inside ORDER BY expressions were not being rewritten correctly. The rewrite flow was missing these cases during parameter processing.
This change updates the rewrite handling and adds regression test coverage for the behavior.
Example
Query:
Before this change, the named parameter inside the ORDER BY expression was not rewritten correctly.
After this change, sqlc.arg(name) is properly detected and rewritten during parameter processing.
Changes
go test ./internal/sql/rewrite