This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -98,4 +98,30 @@ func bumpCounter(ctx context.Context, db *pgx.Conn, queries *tutorial.Queries, i
}
return tx.Commit(ctx)
}
```
```
## Concurrent read-modify-write
The `bumpCounter` example reads a row and then writes a value derived from it.
Under the default isolation level (`READ COMMITTED`), two transactions running
`bumpCounter` concurrently can both read the same `counter`, both write
`counter + 1`, and one update is lost.
When a write depends on a value read earlier in the same transaction, lock the
row on read with `SELECT ... FOR UPDATE` (supported by PostgreSQL and
MySQL/InnoDB):
```sql
-- name: GetRecordForUpdate :one
SELECT * FROM records
WHERE id = $1
FOR UPDATE;
```
Call `GetRecordForUpdate` in place of `GetRecord`; the second transaction then
blocks until the first commits, and reads the updated value.
Alternatively, run the transaction at `SERIALIZABLE` isolation and retry on
serialization failures. sqlc does not manage isolation levels or retries — set
the isolation level when you begin the transaction and handle the retry loop in
your application code.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs(transactions): note the lost-update risk in read-modify-write #4593
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
docs(transactions): note the lost-update risk in read-modify-write #4593
Filter by extension
Viewed files
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing