fix(better-sqlite3): Emit correct types instead of any by donbernar · Pull Request #65 · sqlc-dev/sqlc-gen-typescript · GitHub

Sqlite's driver was not generating types properly, it was returning all columns as any attributes instead of inferring the type from the schema.

Here's an example:

-- schema.sql
CREATE TABLE tenants (
  id TEXT PRIMARY KEY,
  name TEXT NOT NULL,
  slug TEXT NOT NULL UNIQUE,
  deleted INTEGER NOT NULL DEFAULT 0,
  company_tin TEXT NOT NULL UNIQUE
);

Source file:

-- name: Find :one
SELECT * FROM tenants
WHERE id = ?;

Generated code:

// ...

export interface FindArgs {
    id: any;
}

export interface FindRow {
    id: any;
    name: any;
    slug: any;
    deleted: any;
    companyTin: any;
}
// ...

When debugging the driver I noticed the received Column in the columnType method where:

const example1 = {
  name: "id",
  notNull: true,
  isArray: false,
  comment: "",
  length: -1,
  isNamedParam: false,
  isFuncCall: false,
  scope: "",
  table: { catalog: "", schema: "", name: "tenants" },
  tableAlias: "",
  type: { catalog: "", schema: "", name: "TEXT" },
  isSqlcSlice: false,
  originalName: "id",
  unsigned: false,
  arrayDims: 0,
};

const example2 = {
  name: "deleted",
  notNull: true,
  isArray: false,
  comment: "",
  length: -1,
  isNamedParam: false,
  isFuncCall: false,
  scope: "",
  table: { catalog: "", schema: "", name: "tenants" },
  tableAlias: "",
  type: { catalog: "", schema: "", name: "INTEGER" },
  isSqlcSlice: false,
  originalName: "deleted",
  unsigned: false,
  arrayDims: 0,
};

I decided to convert the column.type.name to lowercase and add TEXT and VARCHAR types to the switch case. After building the wasm module, I run it with examples/sqlc.dev.yaml config file and the example file got updated.

While working on this I noticed the Makefile is not compatible with the latest javy CLI version. I have not updated it in the PR, but changing line 8 with the following solved the issues:

fix(better-sqlite3): Emit correct types instead of any

b97b528

fix(better-sqlite3): Emit correct types instead of any by donbernar · Pull Request #65 · sqlc-dev/sqlc-gen-typescript · GitHub

Uh oh!

fix(better-sqlite3): Emit correct types instead of any - #65

fix(better-sqlite3): Emit correct types instead of any#65
donbernar wants to merge 1 commit into
sqlc-dev:mainfrom
donbernar:main

donbernar commented Oct 8, 2025

Uh oh!

donbernar commented Oct 8, 2025 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(better-sqlite3): Emit correct types instead of any by donbernar · Pull Request #65 · sqlc-dev/sqlc-gen-typescript · GitHub

Uh oh!

fix(better-sqlite3): Emit correct types instead of any - #65

fix(better-sqlite3): Emit correct types instead of any#65donbernar wants to merge 1 commit intosqlc-dev:mainsqlc-dev/sqlc-gen-typescript:mainfrom donbernar:maindonbernar/sqlc-gen-typescript:mainCopy head branch name to clipboard

Conversation

donbernar commented Oct 8, 2025

Uh oh!

donbernar commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix(better-sqlite3): Emit correct types instead of any#65
donbernar wants to merge 1 commit into
sqlc-dev:mainfrom
donbernar:main

donbernar commented Oct 8, 2025 •
edited
Loading