Fixed required properties validation in SQLTester - #37
Open
yureiblack wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
sqlite
pushed a commit
that referenced
this pull request
Apr 11, 2026
%#37;. This avoids lots of quoting problems when trying to specify prompt strings in various programming languages and shells. FossilOrigin-Name: e7e6ecc45dfe1a163d259be26877bd7e528ce154e73b3ca8ab7edc5aa94d2d02
sqlite
pushed a commit
that referenced
this pull request
Apr 12, 2026
…racter, since % and just about every other punctuation character is special to cmd.exe, batch files, and nmake, on Windows. FossilOrigin-Name: 79a8d3edf8207d72f0c4650272ee239a1c7783a07f907fbf0cf5a7ad99b27a2a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Fixes
1. Removed Unconditional Early Return Blocking Validation
the #checkRequiredProperties() method from executing its validation logic.
2. Added Missing break in INCRVACUUM Switch Case
default case.
Result
These changes ensure that all required properties —
RECURSIVE_TRIGGERS, TEMPSTORE_FILE, TEMPSTORE_MEM, AUTOVACUUM, and INCRVACUUM —
are now properly validated and applied within the test scripts.