FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow the user can change MaxRecentFiles by lucydodo · Pull Request #2373 · sqlitebrowser/sqlitebrowser · GitHub

Allow the user can change MaxRecentFiles - #2373

Merged
MKleusberg merged 4 commits into
sqlitebrowser:masterfrom
lucydodo:dev
Aug 17, 2020
Merged

Allow the user can change MaxRecentFiles#2373
MKleusberg merged 4 commits into
sqlitebrowser:masterfrom
lucydodo:dev

Conversation

lucydodo commented Aug 15, 2020
edited
Loading

Copy link
Copy Markdown
Member

I recently made a pull request(#2347) to move the recent file list to a sub-menu and
received a suggestion to change the value of MaxRecentFiles during the review process.

Accordingly, I modified the code to allow the user to change the value of MaxRecentFiles.
In addition, I re-added the separator that was lost according to the existing patch.

Thank you.

Test Environment

  • macOS Catalina (10.15.6, 19G2021)

justinclift added the enhancement Feature requests. label Aug 15, 2020
lucydodo changed the title User can change MaxRecentFiles Allow the user can change to the value of MaxRecentFiles Aug 17, 2020
lucydodo changed the title Allow the user can change to the value of MaxRecentFiles Allow the user can change MaxRecentFiles Aug 17, 2020

Copy link
Copy Markdown
Member Author

May I ask for a review of my code?

Copy link
Copy Markdown
Member

@lucydodo Sure. I'll have a look later today 😄

Copy link
Copy Markdown
Member

Thanks, @lucydodo! Looks good 👍

MKleusberg merged commit 54ee47b into sqlitebrowser:master Aug 17, 2020

Copy link
Copy Markdown
Member Author

Thanks to merge!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL