Try to avoid dirty writes when crash while saving project file - #3888
Open
yfdyh000 wants to merge 1 commit into
Open
Try to avoid dirty writes when crash while saving project file#3888yfdyh000 wants to merge 1 commit into
yfdyh000 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for your contribution, but if you weren't able to reproduce on master branch, I'd need more explanations on why this is needed. There were two fixes since v3.13.1: 5d84f53 and the one you mentioned from #3662 (comment) (fdc4169) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This is a logical modification to prevent unprepared content from being written to the file successively at xml(&file). In the past, if the preparation process was interrupted, this could not be rolled back, i.e. non-atomicity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect this to mitigate dirty writes caused by XML build failures, although it is not sufficient for disk errors unless further safe writing methods are implemented, such as .tmp file and moving.
I encountered a crash issue (due to a detached attached database via execute SQL command) in version 3.13.1, which led to the loss of the project file, although I am unable to reproduce the crash on the master branch (this seem fixed by #3662 (comment)).