Fix for issue #592, json query fix when question mark is used in data - #628
Fix for issue #592, json query fix when question mark is used in data#628kamisoft-fr wants to merge 19 commits into
Conversation
Sorry, something went wrong.
|
Any update on this PR? It would be great if we could have it merged :) |
Sorry, something went wrong.
|
I highly upvote this |
Sorry, something went wrong.
👇 Click on the image for a new way to code review
Legend |
Sorry, something went wrong.
This workflow automates the build and test process for a .NET project on push and pull request events to the main branch.
Added SQL Server service container and updated installation steps for sqlcmd tools.
- Add Clone() method to Include class for deep copying - Fix Query.Clone() to deep-copy Includes list and Variables dictionary - Fix XQuery.Clone() with same deep-copy fixes - Add unit tests for the clone bug (independent list, objects, dict, properties) Fixes sqlkata#747 Agent-Logs-Url: https://github.com/sqlkata/querybuilder/sessions/d82ad628-73f5-4c2f-b56e-f4021ce1519f Co-authored-by: ahmad-moussawi <2517523+ahmad-moussawi@users.noreply.github.com>
Fix Query.Clone() shallow copy of Includes and Variables
|
Hi, I came back in this repo and cleaned my pull request since there is now a "main" branch and parameterPlaceHolder management |
Sorry, something went wrong.
Fix places where the parameterPlaceholder is hardcoded to a question mark ?
Since the SqlResult still contained ToString method which had the hardcoded placeholder, here is what I've done:
There is so a breaking change on the SqlResult class since its public, So the sqlkata version would be changed as major (2 to 3 or 3 to 4)