FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rework : solving problem of saving result of --sql-query in CSV file by Aridhi-Dhia-eddine · Pull Request #5685 · sqlmapproject/sqlmap · GitHub

Rework : solving problem of saving result of --sql-query in CSV file - #5685

Open
Aridhi-Dhia-eddine wants to merge 4 commits into
sqlmapproject:masterfrom
Aridhi-Dhia-eddine:my-sqlmap-contribution
Open

Rework : solving problem of saving result of --sql-query in CSV file#5685
Aridhi-Dhia-eddine wants to merge 4 commits into
sqlmapproject:masterfrom
Aridhi-Dhia-eddine:my-sqlmap-contribution

Conversation

Copy link
Copy Markdown

Imran-imtiaz48 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Review Analysis:

  1. Code Formatting and Structure:
    o Both old and new code snippets appear identical in terms of functionality and structure. They iterate over temp_res and s lists to update a dictionary d and append it to dt_save. The subsequent conditional check for len(queryRes) also remains the same.
    Improvement Suggestions:
  2. Documentation and Comments:
    o Consider adding comments or documentation within the code to clarify the purpose of each section (#*******************************************). This helps new developers understand the logic or intention behind that specific block of code.
  3. Error Handling and Validation:
    o Ensure that the conditional check if(len(queryRes)!=0): is accompanied by appropriate error handling or validation logic if queryRes could potentially be None or of unexpected length. Robust error handling improves code reliability.
  4. Consistency and Best Practices:
    o Review the entire codebase for consistency in variable naming (temp_res, s, d, dt_save, file_csv, queryRes, etc.) and adhere to best practices such as using meaningful variable names and following a consistent indentation style.
    Conclusion:
    The provided code snippets show consistency in functionality between the old and new versions. To enhance the GitHub repository, focus on improving documentation clarity, ensuring error handling, and maintaining code consistency. These practices contribute to better readability, maintainability, and reliability of the codebase.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL