FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(superset): Add patch to pin the sax package to 1.2.4 by Techassi · Pull Request #1363 · stackabletech/docker-images · GitHub

fix(superset): Add patch to pin the sax package to 1.2.4 - #1363

Merged
Techassi merged 2 commits into
mainfrom
fix/superset-pin-sax-dependency
Dec 17, 2025
Merged

fix(superset): Add patch to pin the sax package to 1.2.4#1363
Techassi merged 2 commits into
mainfrom
fix/superset-pin-sax-dependency

Conversation

Techassi commented Dec 16, 2025
edited
Loading

Copy link
Copy Markdown
Member

This PR pins the sax package of Superset (frontend) 4.1.x to 1.2.4 in order to fix the following issue encountered since the last few scheduled CI runs:

npm error Invalid: lock file's sax@1.2.4 does not satisfy sax@1.4.3

This error is very similar to errors fixed in #1315 and #1316. This is a known weakness/bug in npm.

Local test builds of Superset 4.1.2 and 4.1.4 succeeded with this fix, and a test build in CI also succeeded: https://github.com/stackabletech/docker-images/actions/runs/20274450552

Apparently my version of git dropped the last character of both
commit IDs. This might be a thing to investigate down the line.
Techassi self-assigned this Dec 16, 2025
Techassi moved this to Development: In Progress in Stackable Engineering Dec 16, 2025

NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Techassi added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 5b12040 Dec 17, 2025
29 of 30 checks passed
Techassi deleted the fix/superset-pin-sax-dependency branch December 17, 2025 07:53
Techassi moved this from Development: In Progress to Development: Done in Stackable Engineering Dec 17, 2025
lfrancke moved this from Development: Done to Done in Stackable Engineering Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL