FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci(reusable_build_image): Add support for nested boil images by NickLarsenNZ · Pull Request #1474 · stackabletech/docker-images · GitHub

ci(reusable_build_image): Add support for nested boil images - #1474

Merged
NickLarsenNZ merged 2 commits into
mainfrom
fix/workflow-support-precompiled
Apr 21, 2026
Merged

ci(reusable_build_image): Add support for nested boil images#1474
NickLarsenNZ merged 2 commits into
mainfrom
fix/workflow-support-precompiled

Conversation

NickLarsenNZ commented Apr 20, 2026
edited
Loading

Copy link
Copy Markdown
Member

Needed so that boil can find the config via the 'product-name', while using the 'namespace' and 'image-name' (without the parent directory) to tag the image with before pushing.

Details

The build action uses the product-name to locate the boil config. Eg:

product-name: hadoop # reads hadoop/boil-config.toml
namespace: sdp # this is used when the image is tagged

This broke twice when I wanted to build precompiled/hadoop:

product-name: hadoop
namespace: precompiled # want to put it in a different project in Harbor

That built the product image via hadoop/boil-config.toml.

So I changed it to:

product-name: precompiled/hadoop # Now it builds the hadoop source
namespace: precompiled # but now we have a duplicate "precompiled" when tagging the image

Waiting on two workflow runs (to ensure it fixes the issue and doesn't break existing stuff):

  • 🟢 precompiled/hadoop (nested)
    • Correctly builds and publishes oci.stackable.tech/precompiled/hadoop:3.4.2-stackable1776715076
  • 🟢 vector (not nested, and relatively fast)
    • Correctly builds and publishes oci.stackable.tech/sdp/vector:0.52.0-stackable0.0.0-dev

Note: Needed so that boil can find the config via the 'product-name', while using the 'namespace' and 'image-name' (without the parent directory) to tag the image with before pushing.

soenkeliebau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As discussed in Slack, discussed with and approved by Sascha. Approval for expediency

soenkeliebau added this pull request to the merge queue Apr 21, 2026
NickLarsenNZ removed this pull request from the merge queue due to a manual request Apr 21, 2026
NickLarsenNZ added this pull request to the merge queue Apr 21, 2026
NickLarsenNZ moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 21, 2026
Merged via the queue into main with commit 5f4a685 Apr 21, 2026
3 checks passed
NickLarsenNZ deleted the fix/workflow-support-precompiled branch April 21, 2026 06:10
lfrancke moved this from Development: Done to Done in Stackable Engineering May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL