fix(boil): Improve VersionExt::is_floating impl - #1571
Merged
Techassi merged 2 commits intoJul 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This commit contains two improvements to the VersionExt::is_floating function: 1. It relaxes the requirements for 0.0.0-dev versions to be able to include extra tag data, eg. 0.0.0-dev-pr123 2. It now uses a regular expression to check whether the prerelease string is considered floating. The previous solution was too limited to catch more complicated patterns.
sbernauer
previously approved these changes
Jul 7, 2026
NickLarsenNZ
reviewed
Jul 7, 2026
Comment thread
rust/boil/src/utils.rs
NickLarsenNZ
approved these changes
Jul 7, 2026
NickLarsenNZ
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit contains two improvements to the VersionExt::is_floating function:
Came up in https://github.com/stackabletech/actions/actions/runs/28854067368/job/85576153193?pr=116.