FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(hbase): remove dependency on htrace by razvan · Pull Request #820 · stackabletech/docker-images · GitHub

/ docker-images Public

fix(hbase): remove dependency on htrace - #820

Draft
razvan wants to merge 11 commits into
mainfrom
chore/update-jackson-databind
ConversationCommits (11)ChecksFiles changed
Draft

fix(hbase): remove dependency on htrace#820
razvan wants to merge 11 commits into
mainfrom
chore/update-jackson-databind

Conversation

razvan commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Part of #816

Relevant comment: #816 (comment)

Images are building successfully: https://github.com/stackabletech/docker-images/actions/runs/10664458546

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

razvan mentioned this pull request Aug 30, 2024
Open
5 tasks
razvan changed the title fix(hbase): remove dependency on jackson-databind 2.4.0 fix(hbase): remove old jackson-databind dependency from Phoenix Aug 30, 2024
razvan marked this pull request as ready for review September 2, 2024 09:23
razvan requested a review from a team September 2, 2024 09:24
NickLarsenNZ reviewed Sep 9, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread hbase/README.md Outdated
razvan and others added 3 commits September 9, 2024 10:05
Update CHANGELOG.md
0562f40 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Update hbase/README.md
6da8ca4 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
main merge
cd8760a

NickLarsenNZ commented Sep 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Re: the hadolint failure, I stumbled across this today: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/

Maybe we need to update the syntax for the Dockerfile for hadolint to accept the heredoc?

Although, there is already an issue for hadolint: hadolint/hadolint#806

razvan marked this pull request as draft September 10, 2024 12:00

razvan commented Sep 10, 2024

Copy link
Copy Markdown
Member Author

Converted to draft again, since:

  • we are now removing htrace completely and not just jackson-databind 2.4.0
  • is wip

razvan changed the title fix(hbase): remove old jackson-databind dependency from Phoenix fix(hbase): remove dependency on htrace Sep 10, 2024
NickLarsenNZ reviewed Sep 11, 2024
View reviewed changes
Comment thread hbase/versions.py
"java-devel": "11",
"async_profiler": "2.9",
"phoenix": "5.3.0-4afe457",
"phoenix": "5.3.0-ca21a87dd6",

NickLarsenNZ Sep 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we add a comment next to this to show where it comes from?

Also, common short-hash is 7 characters long (unless there is a new recommendation to avoid collisions)?

Suggested change
"phoenix": "5.3.0-ca21a87dd6",
"phoenix": "5.3.0-ca21a87", # This is currently manually built and uploaded to Nexus

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NickLarsenNZ NickLarsenNZ left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL