[Merged by Bors] - Tls authentication and encryption - #479
Closed
maltesander wants to merge 28 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…settings (secret and authentication class hard coded atm)
…d_encryption # Conflicts: # Cargo.lock # rust/operator-binary/Cargo.toml
3 tasks
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
maltesander
marked this pull request as ready for review
May 9, 2022 13:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
Comment thread
tests/templates/kuttl/smoke/test_tls.sh
Outdated
adwk67
self-requested a review
May 11, 2022 07:49
sbernauer
reviewed
May 11, 2022
Comment thread
deploy/config-spec/properties.yaml
Outdated
sbernauer
reviewed
May 11, 2022
Comment thread
rust/operator-binary/src/zk_controller.rs
Outdated
adwk67
reviewed
May 11, 2022
Comment thread
docs/modules/ROOT/pages/usage.adoc
Outdated
Comment thread
docs/modules/ROOT/pages/usage.adoc
Outdated
Comment thread
docs/modules/ROOT/pages/usage.adoc
Outdated
Comment thread
docs/modules/ROOT/pages/usage.adoc
Outdated
Comment thread
rust/operator-binary/src/command.rs
Outdated
Comment thread
rust/operator-binary/src/command.rs
Outdated
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
adwk67
approved these changes
May 11, 2022
adwk67
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
sbernauer
approved these changes
May 11, 2022
Copy link
Copy Markdown
Member
Author
|
bors merge |
Sorry, something went wrong.
bors Bot
pushed a commit
that referenced
this pull request
May 11, 2022
## Description closes #466 Currently there is still a workaround (TLS can be used via the `clientPort` and not `secureClientPort` with port unification. This means there still can be plaintext connections without encryption or authentication; see https://issues.apache.org/jira/browse/ZOOKEEPER-4276) Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Copy link
Copy Markdown
Contributor
|
Pull request successfully merged into main. Build succeeded: |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #466
Currently there is still a workaround (TLS can be used via the clientPort and not secureClientPort with port unification. This means there still can be plaintext connections without encryption or authentication; see https://issues.apache.org/jira/browse/ZOOKEEPER-4276)
Review Checklist
Once the review is done, comment bors r+ (or bors merge) to merge. Further information