feat: use Google Tag Manager gtm.js instead of gtag.js - #189
Merged
fvsch merged 3 commits intoDec 15, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
✅ Deploy Preview for stackblitz-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry, something went wrong.
fvsch
commented
Dec 14, 2023
Comment thread
.vitepress/config.ts
|
|
||
| const BASE = '/'; | ||
| const BASE_WITH_ORIGIN = `https://developer.stackblitz.com${BASE}`; | ||
| const BASE_PATH = '/'; |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
💅 Unrelated cosmetic changes: renamed a constant, and tweaked formatting (running Prettier).
Sorry, something went wrong.
fvsch
requested review from
peter-zawistowicz
and removed request for
AleksandrSl
December 14, 2023 18:16
fvsch
force-pushed
the
fvsch/update-gtm
branch
from
118bd3a to
c4b94b5
Compare
December 14, 2023 19:48
fvsch
force-pushed
the
fvsch/update-gtm
branch
from
c4b94b5 to
4d58d40
Compare
December 14, 2023 19:52
peter-zawistowicz
approved these changes
Dec 15, 2023
peter-zawistowicz
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
✅ 🙏
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MKT-69.
This PR updates the analytics snippet code to load both /gtm.js and /gtag/js.