FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: cleanup GA code and more by fvsch · Pull Request #214 · stackblitz/docs · GitHub

/ docs Public

chore: cleanup GA code and more - #214

Merged
donmckenna merged 3 commits into
mainfrom
fvsch/update-to-gtm
Mar 28, 2024
ConversationCommits (3)ChecksFiles changed
Merged

chore: cleanup GA code and more#214
donmckenna merged 3 commits into
mainfrom
fvsch/update-to-gtm

Conversation

fvsch commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

This PR:

  • Removes support for adding a Google Analytics code snippet with the VITE_GTAG_ID environment variable. We now only support VITE_GTM_ID (for Google Tag Manager).
  • Removes a file that looks like a compilation output that was introduced in feat: add storybook and figma pages #192 (I haven't identified what process generated the file, but we most likely don't want it).

bolt-new-by-stackblitz Bot commented Mar 25, 2024

Copy link
Copy Markdown

Run & review this pull request in StackBlitz Codeflow.

stackblitz-staging Bot commented Mar 25, 2024

Copy link
Copy Markdown

Run & review this pull request in StackBlitz Codeflow.

netlify Bot commented Mar 25, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for stackblitz-docs ready!

Name Link
🔨 Latest commit bc373b9
🔍 Latest deploy log https://app.netlify.com/sites/stackblitz-docs/deploys/6604d41536085600089f33e2
😎 Deploy Preview https://deploy-preview-214--stackblitz-docs.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

donmckenna approved these changes Mar 28, 2024
View reviewed changes

donmckenna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🙏

donmckenna merged commit 54aa743 into main Mar 28, 2024
donmckenna deleted the fvsch/update-to-gtm branch March 28, 2024 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sulco Awaiting requested review from sulco
peter-zawistowicz Awaiting requested review from peter-zawistowicz
1 more reviewer
donmckenna donmckenna approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL