FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions by titomiguelcosta · Pull Request #39 · stackery/php-lambda-layer · GitHub

This repository was archived by the owner on Sep 8, 2021. It is now read-only.
/ php-lambda-layer Public archive

[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions - #39

Merged
txase merged 2 commits into
stackery:masterfrom
titomiguelcosta:master
May 31, 2019
ConversationCommits (2)ChecksFiles changed
Merged

[PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions#39
txase merged 2 commits into
stackery:masterfrom
titomiguelcosta:master

Conversation

titomiguelcosta commented May 28, 2019

Copy link
Copy Markdown
Contributor

This PR, fixes issue #38

In the end, it was a small fix. When building the php73.zip there were errors in installing remi repo, and it all came down to the order we installed epel and remi, reverting those instructions fixed the problem.

In term of adding the missing extensions required by Symfony 4, I only had to add php-xml and php-process to the list of php packages to be installed.

I tested and deployed the generated layer. phpinfo can be seen here (this page will be deleted once we merge this PR).

Side note: I did not explore, but I wonder why do we need to install httpd as part of building the image?! In my case, I'm using API Gateway to handle the requests and fire the lambda. I might be missing something but I do not think we need apache.

titomiguelcosta commented May 28, 2019

Copy link
Copy Markdown
Contributor Author

To test my PR, just change to my branch and run $ make php73.zip
Done on a Linux Mint 19.1 box with docker 18.09.6, build 481bc77

titomiguelcosta changed the title fixed issue with installing remi repo and added missing PHP extensions [PHP 7.3] fixed issue with installing remi repo and added missing PHP extensions May 28, 2019
titomiguelcosta mentioned this pull request May 28, 2019
Open
txase suggested changes May 31, 2019
View reviewed changes

txase left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me! Can you also update the readme with the additional extensions this provides in the runtime layer?

🙏

titomiguelcosta commented May 31, 2019

Copy link
Copy Markdown
Contributor Author

This looks good to me! Can you also update the readme with the additional extensions this provides in the runtime layer?

@txase sure thing, done. copied the output of the command and put on the README sorted alphabetically

txase merged commit ddc2cf0 into stackery:master May 31, 2019

txase commented May 31, 2019

Copy link
Copy Markdown
Member

Thanks!

I’ll look to update the layer in AWS early next week!

ronald2wing commented Aug 1, 2021

Copy link
Copy Markdown

xmlreader still missing

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
txase txase approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL