FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

skip setting readonly LB fields in the update call by breuerfelix · Pull Request #1233 · stackitcloud/cloud-provider-stackit · GitHub

/ cloud-provider-stackit Public

skip setting readonly LB fields in the update call - #1233

Merged
ske-prow[bot] merged 2 commits into
mainfrom
regression
Jun 16, 2026
ConversationCommits (2)ChecksFiles changed
Merged

skip setting readonly LB fields in the update call#1233
ske-prow[bot] merged 2 commits into
mainfrom
regression

Conversation

breuerfelix commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind regression

What this PR does / why we need it:
After the LB SDK update, creating LoadBalancer did work, but updating them resulted in an issue due to the status being an empty string instead of a nil pointer. We never set the status anyways, so we should remove that. The status should be a "read only" value anyway.
Errors and PrivateAddress are also readonly fields that got removed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

ske-prow Bot added the kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution label Jun 16, 2026
breuerfelix requested a review from a team June 16, 2026 13:25
ske-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2026
ske-prow Bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2026
do not set the lb.status when updating
b91d949 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
ske-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2026
breuerfelix reopened this Jun 16, 2026

breuerfelix commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/hold currently testing in ondemand

ske-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2026
breuerfelix changed the title skip setting lb status in lb update call skip setting readonly LB fields in the update call Jun 16, 2026
remove more readonly fields
32125e6 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
ske-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2026

ske-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 827bd03599514dea0a58801e8a2d0d5a1398ad56

breuerfelix commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

ske-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2026

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: once the present PR merges, I will cherry-pick it on top of release-v1.33, release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

breuerfelix commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/approve

ske-prow Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix, ftl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ske-prow Bot merged commit 7758e1b into main Jun 16, 2026
3 checks passed
ske-prow Bot deleted the regression branch June 16, 2026 14:50

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1234

Details

In response to this:

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jun 16, 2026
Merged

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1235

Details

In response to this:

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jun 16, 2026
Merged

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1236

Details

In response to this:

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jun 16, 2026
Merged

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1237

Details

In response to this:

/unhold tested in ondemand

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jun 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ftl ftl approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL