FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: clarify TODO about setting encryption parameters for `volumeSourceType = backup` is valid by nschad · Pull Request #1397 · stackitcloud/cloud-provider-stackit · GitHub

/ cloud-provider-stackit Public

chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid - #1397

Merged
ske-prow[bot] merged 1 commit into
mainfrom
clarify-todo-encryption
Jul 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid#1397
ske-prow[bot] merged 1 commit into
mainfrom
clarify-todo-encryption

Conversation

nschad commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

How to categorize this PR?

/kind task

What this PR does / why we need it:

TODO removed. Implementation was correct, added some more input

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

chore: clarify TODO about setting encryption parameters for volumeSou…
44b7ca7 
…rceType==backup is valid

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
ske-prow Bot added kind/task General task size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2026
nschad changed the title chore: clarify TODO about setting encryption parameters for volumeSourceType==backup is valid chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid Jul 20, 2026

nschad commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

stackit-ske commented Jul 20, 2026

Copy link
Copy Markdown

@nschad: once the present PR merges, I will cherry-pick it on top of release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nschad changed the title chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid chore: clarify TODO about setting encryption parameters for volumeSourceType = backup is valid Jul 20, 2026
ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026

ske-prow Bot commented Jul 23, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 4102571db3caef9586f6ce4b9a69a21e65c860e6

ske-prow Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kumm-Kai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
ske-prow Bot merged commit 758622a into main Jul 23, 2026
3 checks passed
ske-prow Bot deleted the clarify-todo-encryption branch July 23, 2026 14:39

stackit-ske commented Jul 23, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1403

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jul 23, 2026
Merged

stackit-ske commented Jul 23, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1404

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jul 23, 2026
Merged

stackit-ske commented Jul 23, 2026

Copy link
Copy Markdown

@nschad: new pull request created: #1407

Details

In response to this:

/cherry-pick release-v1.34
/cherry-pick release-v1.35
/cherry-pick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stackit-ske mentioned this pull request Jul 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kumm-Kai Kumm-Kai approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/task General task lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL